Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpio: Add GPIO Definitions for H562/3 & H573 families #32

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

astapleton
Copy link
Contributor

This adds the required definitions to use the GPIO driver on H562/3 & H573 parts.

src/gpio/gpio_def.rs Outdated Show resolved Hide resolved
PA12: (pa12, 12, [1, 3, 5, 6, 7, 8, 9, 10, 15]),
PA13: (pa13, 13, [0, 15], crate::gpio::Debugger),
PA14: (pa14, 14, [0, 15], crate::gpio::Debugger),
PA15: (pa15, 15, [0, 1, 2, 4, 5, 6, 7, 8, 11, 12, 13, 14, 15], crate::gpio::Debugger),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is considered a debug pin(JTDI) then it should be for H503 too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PA15 is marked as such for the H503

src/gpio/gpio_def.rs Outdated Show resolved Hide resolved
src/gpio/gpio_def.rs Outdated Show resolved Hide resolved
src/gpio/gpio_def.rs Outdated Show resolved Hide resolved
src/gpio/gpio_def.rs Outdated Show resolved Hide resolved
@astapleton
Copy link
Contributor Author

@usbalbin I got a bit trigger happy with that debugger initial state, it seems! Fixed it so only pins listed in the reference manual as being in an alternate function push-pull configuration for debugging were marked as such.

@usbalbin
Copy link
Member

@usbalbin I got a bit trigger happy with that debugger initial state, it seems! Fixed it so only pins listed in the reference manual as being in an alternate function push-pull configuration for debugging were marked as such.

I am not familiar with what it affect or does in the hal, just noticed the difference between the MCUs

@astapleton
Copy link
Contributor Author

@usbalbin I got a bit trigger happy with that debugger initial state, it seems! Fixed it so only pins listed in the reference manual as being in an alternate function push-pull configuration for debugging were marked as such.

I am not familiar with what it affect or does in the hal, just noticed the difference between the MCUs

It marks these pins as being in an alternate function initial state on reset, instead of the analog state all other GPIOs reset to:
Screenshot 2025-01-10 at 11 08 49

@astapleton
Copy link
Contributor Author

@usbalbin Anything blocking getting your approval on this? I'll merge if you +1 this so we can move on to including the H523/H533 GPIOs.

@astapleton astapleton merged commit 9c0bf58 into master Jan 25, 2025
15 checks passed
@astapleton astapleton deleted the as/gpio-h567 branch January 25, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants